Bug 242039 - Download::platformCancelNetworkLoad() may call its completion handler on the wrong thread
Summary: Download::platformCancelNetworkLoad() may call its completion handler on the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-27 16:34 PDT by Chris Dumez
Modified: 2022-06-27 18:00 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-06-27 16:34:24 PDT 
Download::platformCancelNetworkLoad() may call its completion handler on the wrong thread, leading to crashes in the Timer destructor because the Download object gets destroyed off the main thread.
Comment 1 Chris Dumez 2022-06-27 16:34:36 PDT 
<rdar://74650424>
Comment 2 Chris Dumez 2022-06-27 16:37:17 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/1837
Comment 3 EWS 2022-06-27 18:00:05 PDT 
Committed 251897@main (ac21d7522331): <https://commits.webkit.org/251897@main>

Reviewed commits have been landed. Closing PR #1837 and removing active labels.