Bug 241880 - AX: PAL::getAVSpeechSynthesisVoiceClass() is called without first checking isAVFoundationFrameworkAvailable
Summary: AX: PAL::getAVSpeechSynthesisVoiceClass() is called without first checking is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-22 15:33 PDT by Tyler Wilcock
Modified: 2022-06-23 22:26 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2022-06-22 15:36 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (1.96 KB, patch)
2022-06-23 11:13 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-06-22 15:33:30 PDT 
This causes a crash since we need AVFoundationFramework to get the voice list.
Comment 1 Radar WebKit Bug Importer 2022-06-22 15:33:39 PDT 
<rdar://problem/95728748>
Comment 2 Tyler Wilcock 2022-06-22 15:36:32 PDT 
Created attachment 460431 [details]
Patch
Comment 3 Tyler Wilcock 2022-06-22 15:39:44 PDT 
rdar://94193185
Comment 4 chris fleizach 2022-06-23 10:07:21 PDT 
Comment on attachment 460431 [details]
Patch

can you also add this in
- (void)speakUtterance:(RefPtr<WebCore::PlatformSpeechSynthesisUtterance>&&)utterance

then I think we'll cover our cases
Comment 5 Tyler Wilcock 2022-06-23 11:13:54 PDT 
Created attachment 460451 [details]
Patch
Comment 6 EWS 2022-06-23 22:26:09 PDT 
Committed 251821@main (52f3c697fae9): <https://commits.webkit.org/251821@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460451 [details].