Bug 241793 - Remove local bounds from DrawGlyphs and DrawDecomposedGlyphs display list items
Summary: Remove local bounds from DrawGlyphs and DrawDecomposedGlyphs display list items
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Process Model (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-20 18:28 PDT by Cameron McCormack (:heycam)
Modified: 2022-07-13 23:32 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2022-06-20 18:28:19 PDT 
These fields exist only because the localBounds() function on display list items doesn't have access to the relevant resources, only the resource ID. This patch passes the resource heap into localBounds() so that DrawGlyphs and DrawDecomposedGlyphs can compute bounds on the fly. This lets us avoid sending the bounds over IPC too.
Comment 1 Cameron McCormack (:heycam) 2022-06-20 18:30:28 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/1642
Comment 2 Radar WebKit Bug Importer 2022-06-27 18:29:12 PDT 
<rdar://problem/96027465>
Comment 3 EWS 2022-07-13 23:32:06 PDT 
Committed 252442@main (d05bc644486e): <https://commits.webkit.org/252442@main>

Reviewed commits have been landed. Closing PR #1642 and removing active labels.