Bug 241352 - Some trustd network requests are not attributed to the UIProcess
Summary: Some trustd network requests are not attributed to the UIProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-06 15:29 PDT by Ben Nham
Modified: 2022-06-07 10:48 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2022-06-06 15:29:27 PDT 
Some of the calls to SecTrustEvaluate (in particular the one in ResourceResponseCocoa) are not made with a corresponding call to SecTrustSetClientAuditToken. As a result, if trustd ends up making a network request to fulfill that API request (e.g. for OCSP verification), the corresponding network request is misattributed to NetworkProcess rather than the UIProcess. To fix this, we add a call to SecTrustSetClientAuditToken in ResourceResponse::platformCertificateInfo.
Comment 1 Ben Nham 2022-06-06 15:34:47 PDT 
rdar://91322555
Comment 2 Ben Nham 2022-06-06 15:45:30 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/1335
Comment 3 EWS 2022-06-07 10:48:47 PDT 
Committed r295357 (251366@main): <https://commits.webkit.org/251366@main>

Reviewed commits have been landed. Closing PR #1335 and removing active labels.