Bug 241323 - [LFC][FFC] Populate canUseForFlexLayout with unsupported styles and content
Summary: [LFC][FFC] Populate canUseForFlexLayout with unsupported styles and content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-05 21:33 PDT by zalan
Modified: 2022-06-06 06:09 PDT (History)
5 users (show)

See Also:

Attachments
[fast-cq]Patch (2.50 KB, patch)
2022-06-05 21:35 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-06-05 21:33:13 PDT 
ssia
Comment 1 zalan 2022-06-05 21:35:16 PDT 
Created attachment 460044 [details]
[fast-cq]Patch
Comment 2 Tim Nguyen (:ntim) 2022-06-06 01:42:44 PDT 
Comment on attachment 460044 [details]
[fast-cq]Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460044&action=review

nice

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:697
> +        if (flexItem.isFloating() || flexItem.isOutOfFlowPositioned())

I'm pretty sure `float` has no effect on flex items. See:

data:text/html,<div style="display: flex;"><div style="float: right; width: 200px; height: 200px; background: red"></div></div>

or 

data:text/html,<div style="display: flex;">dsdfdsofjdskfdslvndlcvnfsldjnvdfoskgdfjngfdjnfdljgksdfngfdlg<div style="float: left; width: 200px; height: 200px; background: red"></div></div>

I could be wrong though
Comment 3 EWS 2022-06-06 06:08:43 PDT 
Committed r295282 (251328@main): <https://commits.webkit.org/251328@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460044 [details].
Comment 4 Radar WebKit Bug Importer 2022-06-06 06:09:13 PDT 
<rdar://problem/94432777>