Bug 241313 - [LFC][FFC] column-reverse content should take resolved flex box height into account when computing visual position
Summary: [LFC][FFC] column-reverse content should take resolved flex box height into a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-06-04 20:43 PDT by zalan
Modified: 2022-06-05 17:05 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.90 KB, patch)
2022-06-04 20:51 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (1.89 KB, patch)
2022-06-04 21:35 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-06-04 20:43:56 PDT 
ssia
Comment 1 zalan 2022-06-04 20:51:52 PDT 
Created attachment 460034 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2022-06-04 21:07:13 PDT 
Comment on attachment 460034 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460034&action=review

> Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:268
> +            auto pyhsicalBottom = constraints.logicalTop() + constraints.availableVerticalSpace().value_or(logicalWidth);

pyhsical
Comment 3 zalan 2022-06-04 21:35:19 PDT 
Created attachment 460036 [details]
Patch
Comment 4 zalan 2022-06-04 21:36:26 PDT 
(In reply to Tim Nguyen (:ntim) from comment #2)
> Comment on attachment 460034 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=460034&action=review
> 
> > Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:268
> > +            auto pyhsicalBottom = constraints.logicalTop() + constraints.availableVerticalSpace().value_or(logicalWidth);
> 
> pyhsical
lol, so this made me change it to my preferred term of 'visual".
Comment 5 EWS 2022-06-05 17:04:20 PDT 
Committed r295273 (251319@main): <https://commits.webkit.org/251319@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460036 [details].
Comment 6 Radar WebKit Bug Importer 2022-06-05 17:05:13 PDT 
<rdar://problem/94410703>