Bug 241304 - Implement text-justify: none;
Summary: Implement text-justify: none;
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 99945
  Show dependency tree / graph
 
Reported: 2022-06-04 05:41 PDT by Tim Nguyen (:ntim)
Modified: 2024-07-11 19:26 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-06-04 05:41:20 PDT 
The original implementation for legacy layout in bug 135349 had the issue that it didn't take in account text-align-last: justify; (if text-align is different than justify).

IFC does not implement text-justify: none.

So I removed the existing legacy layout implementation of text-justify: none in https://github.com/WebKit/WebKit/pull/1308 to avoid confusion.


I think it should be easy to add support for both modern and legacy layouts, however it's probably worth refactoring to avoid duplicating the logic.
Comment 1 Tim Nguyen (:ntim) 2022-06-04 05:45:49 PDT 
One testcase that would be nice to add is:

text-align: end;
text-align-last: justify;
text-justify: none;

Currently, I think legacy layout handles this incorrectly, as the last line will still be justified.
Comment 2 Radar WebKit Bug Importer 2022-06-11 05:42:15 PDT 
<rdar://problem/94879056>