Bug 241111 - [LFC][FFC] Add support for margin: auto
Summary: [LFC][FFC] Add support for margin: auto
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-30 15:14 PDT by zalan
Modified: 2022-05-31 09:09 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.71 KB, patch)
2022-05-30 16:10 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (11.71 KB, patch)
2022-05-31 05:33 PDT, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-05-30 15:14:11 PDT 
ssia
Comment 1 zalan 2022-05-30 16:10:14 PDT 
Created attachment 459875 [details]
Patch
Comment 2 Antti Koivisto 2022-05-30 21:33:37 PDT 
Comment on attachment 459875 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459875&action=review

> Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:138
> +        if (hasAutoMarginStart || hasAutoMarginEnd)
> +            autoMarginCount += hasAutoMarginStart && hasAutoMarginEnd ? 2 : 1;

if (hasAutoMarginStart)
    ++autoMarginCount;
if (hasAutoMarginEnd)
    ++autoMarginCount;

would be easier to parse.
Comment 3 zalan 2022-05-31 05:33:43 PDT 
Created attachment 459885 [details]
[fast-cq]Patch
Comment 4 EWS 2022-05-31 06:41:10 PDT 
Committed r295051 (251146@main): <https://commits.webkit.org/251146@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459885 [details].
Comment 5 Radar WebKit Bug Importer 2022-05-31 06:42:13 PDT 
<rdar://problem/94147982>