Bug 241097 - [Legacy Line Layout] Parenthesis rendered in the wrong place for Arabic text
Summary: [Legacy Line Layout] Parenthesis rendered in the wrong place for Arabic text
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-30 03:46 PDT by Pablo Saavedra
Modified: 2024-06-29 07:37 PDT (History)
5 users (show)

See Also:

Attachments
Arabic text rendered in WebKit (8.32 KB, image/png)
2022-05-30 03:46 PDT, Pablo Saavedra 		no flags Details
Results using WebKit ToT (Canonical link: https://commits.webkit.org/254090@main) (8.31 KB, image/png)
2022-09-06 06:24 PDT, Pablo Saavedra 		no flags Details
Safari 17.6 Beta vs Other Browsers (227.02 KB, image/png)
2024-06-29 05:20 PDT, Ahmad Saleem 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo Saavedra 2022-05-30 03:46:21 PDT 
Subject says it all.

There is a screenshot attached showing the expected behavior VS the actual rendering.

Page: https://people.igalia.com/psaavedra/arabic.html


```
<html>
<head>
<meta charset="utf-8">
</head>
<body>

<h1> OK </h1>

<p>
ﻢﺛﺎﻟ (ﻩﺫﺍ ﺩﺎﺨﻟ ﻕﻮﺳ)
</p>

<h1> Wrong </h1>

<p>
ﻳً ﻢﺛﺎﻟ (ﻩﺫﺍ ﺩﺎﺨﻟ ﻕﻮﺳ).
</p>
```

Tested in
 
* WPE: 2.36
* GTK: 2.32
* Safari 15.4
Comment 1 Pablo Saavedra 2022-05-30 03:46:56 PDT 
Created attachment 459853 [details]
Arabic text rendered in WebKit
Comment 2 Myles C. Maxfield 2022-05-31 08:43:28 PDT 
Wow this is a very bad bug.
Comment 3 Radar WebKit Bug Importer 2022-05-31 09:07:08 PDT 
<rdar://problem/94155121>
Comment 4 Myles C. Maxfield 2022-06-02 16:50:46 PDT 
When I said "this is a very bad bug" what I meant was "this bug appears to change the semantic meaning of the text it's displaying."
Comment 5 zalan 2022-06-02 17:09:02 PDT 
This has progressed at r288070, when we enabled IFC for complex text. The test case looks fine on trunk with IFC enabled. However currently there are still a handful of properties that could throw us off of the modern line layout codepath and produce incorrect rendering on this content.
Comment 6 Pablo Saavedra 2022-09-06 06:24:07 PDT 
Created attachment 462163 [details]
Results using WebKit ToT (Canonical link: https://commits.webkit.org/254090@main)

Issues are still there.
Comment 7 Pablo Saavedra 2022-10-27 00:56:54 PDT 
I need to check the results again in ToT since Layout Format Code is now the  standard system for inline layout. That means not safeguards involved to activate it. 

Maybe related: https://bugs.webkit.org/show_bug.cgi?id=244711#c4
Comment 8 Ahmad Saleem 2024-06-29 05:20:16 PDT 
Created attachment 471772 [details]
Safari 17.6 Beta vs Other Browsers
Comment 9 Ahmad Saleem 2024-06-29 05:22:06 PDT 
@Alan - anything more needed here?
Comment 10 zalan 2024-06-29 07:37:38 PDT 
(In reply to Ahmad Saleem from comment #9)
> @Alan - anything more needed here?
Nope. This looks all good. Thank you.