241019 – Non unified build fixes, lateish May 2022 edition

Bug 241019 - Non unified build fixes, lateish May 2022 edition

Summary: Non unified build fixes, lateish May 2022 edition

Status:	RESOLVED CONFIGURATION CHANGED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests (show other bugs)
Version:	WebKit Local Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Adrian Perez

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2022-05-27 08:11 PDT by Adrian Perez
Modified:	2022-10-17 15:42 PDT (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Adrian Perez 2022-05-27 08:11:25 PDT

I have a couple of fixes more :]

Comment 1 Adrian Perez 2022-05-27 08:22:35 PDT

Pull request: https://github.com/WebKit/WebKit/pull/1097

Comment 2 EWS 2022-05-27 09:54:54 PDT

Committed r294939 (251050@main): <https://commits.webkit.org/251050@main>

Reviewed commits have been landed. Closing PR #1097 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2022-05-27 09:55:14 PDT

<rdar://problem/94039876>

Comment 4 Mark Lam 2022-05-27 15:27:49 PDT

This is being rolled out in https://github.com/WebKit/WebKit/pull/1124 because it builds on top of https://bugs.webkit.org/show_bug.cgi?id=221260, and we need to roll out https://bugs.webkit.org/show_bug.cgi?id=221260 which broke WASM on 64-bit platforms.

Comment 5 Mark Lam 2022-05-27 15:52:10 PDT

Rolled out here:
Committed r294960 (251064@main): https://commits.webkit.org/251064@main

https://github.com/WebKit/WebKit/commit/9fc9197ae2bd835d510ab87ef9d680bfece85f79

Comment 6 Adrian Perez 2022-10-17 15:42:06 PDT

Patch no longer needed.