Bug 241009 - [JSC] Port and enable Wasm BBQ JIT on ARMv7
Summary: [JSC] Port and enable Wasm BBQ JIT on ARMv7
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-27 06:13 PDT by Geza Lore
Modified: 2022-12-23 02:47 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Geza Lore 2022-05-27 06:13:57 PDT
Patch pending.
Comment 1 Geza Lore 2022-05-27 07:37:49 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1093
Comment 2 Radar WebKit Bug Importer 2022-06-03 06:14:14 PDT
<rdar://problem/94342856>
Comment 3 Joseph Griego 2022-07-05 09:25:30 PDT
Pull request: https://github.com/WebKit/WebKit/pull/2080
Comment 4 Joseph Griego 2022-11-29 11:34:04 PST
Pull request: https://github.com/WebKit/WebKit/pull/6930
Comment 5 EWS 2022-12-13 09:27:54 PST
Committed 257793@main (cac02a1a9807): <https://commits.webkit.org/257793@main>

Reviewed commits have been landed. Closing PR #6930 and removing active labels.
Comment 6 EWS 2022-12-13 12:08:04 PST
Committed 257808@main (189dce5799e8): <https://commits.webkit.org/257808@main>

Reviewed commits have been landed. Closing PR #2080 and removing active labels.
Comment 7 Pablo Saavedra 2022-12-23 02:43:55 PST
Nightly build with

```
./Tools/Scripts/build-webkit --release --wpe '--cmakeargs= 			-DLIBEXEC_INSTALL_DIR=/home/bot/webkit/WebKitBuild/Release/bin/ 			-DLIB_INSTALL_DIR=/home/bot/webkit/WebKitBuild/Release/lib/ 		-DENABLE_DFG_JIT=ON 			-DENABLE_JIT=ON -DENABLE_C_LOOP=OFF 						-DENABLE_ENCRYPTED_MEDIA=OFF 			-DENABLE_MEDIA_STREAM=OFF 						-DUSE_LCMS=OFF -DUSE_SOUP2=ON 			-DENABLE_INTROSPECTION=OFF -DENABLE_DOCUMENTATION=OFF 			-DENABLE_MINIBROWSER=ON -DDEVELOPER_MODE=OFF -DENABLE_WEBXR=OFF -DENABLE_WPE_QT_API=OFF -DENABLE_BUBBLEWRAP_SANDBOX=OFF'
```

fails after applying this commit:

```
commit 189dce5799e8464f6d477a92d8dd7c26c085362d (HEAD)
Author: Joseph Griego <jgriego@igalia.com>
Date:   Tue Dec 13 12:06:30 2022 -0800

    [JSC] Port and enable Wasm BBQ JIT on ARMv7
    https://bugs.webkit.org/show_bug.cgi?id=241009
    
    Reviewed by Justin Michaud.
    
    This patch enables the Wasm BBQ JIT on ARMv7.
```


Error:


```
: && /home/bot/toolchain_env_wandboard-mesa-wpe-candidate/sysroots/x86_64-pokysdk-linux/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-g++   -mthumb -mfpu=neon -mfloat-abi=hard -mcpu=cortex-a9 -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/home/bot/toolchain_env_wandboard-mesa-wpe-candidate/sysroots/cortexa9t2hf-neon-poky-linux-gnueabi --sysroot=/home/bot/toolchain_env_wandboard-mesa-wpe-candidate/sysroots/cortexa9t2hf-neon-poky-linux-gnueabi -fPIC -fdiagnostics-color=always -Wextra -Wall -pipe -fmax-errors=20 -Wno-odr -Wno-stringop-overread -Wno-stringop-overflow -Wno-nonnull -Wno-array-bounds -Wno-expansion-to-defined -Wno-noexcept-type -Wno-uninitialized -Wno-mismatched-new-delete -Wno-psabi -Wno-misleading-indentation -Wno-maybe-uninitialized -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare  -O2 -pipe -g -feliminate-unused-debug-types  -fno-strict-aliasing -fno-exceptions -fno-rtti -O3 -DNDEBUG  -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed  -Wl,-z,relro,-z,now -Wl,--disable-new-dtags -shared  -o lib/libWPEInjectedBundle.so Source/WebKit/CMakeFiles/WPEInjectedBundle.dir/WebProcess/InjectedBundle/API/glib/WebKitInjectedBundleMain.cpp.o  -Wl,-rpath,/home/bot/webkit/WebKitBuild/Release/lib:  lib/libWPEWebKit-1.0.so.3.19.0  /home/bot/toolchain_env_wandboard-mesa-wpe-candidate/sysroots/cortexa9t2hf-neon-poky-linux-gnueabi/usr/lib/libcairo.so  /home/bot/toolchain_env_wandboard-mesa-wpe-candidate/sysroots/cortexa9t2hf-neon-poky-linux-gnueabi/usr/lib/libfreetype.so  /home/bot/toolchain_env_wandboard-mesa-wpe-candidate/sysroots/cortexa9t2hf-neon-poky-linux-gnueabi/usr/lib/libharfbuzz.so  /home/bot/toolchain_env_wandboard-mesa-wpe-candidate/sysroots/cortexa9t2hf-neon-poky-linux-gnueabi/usr/lib/libharfbuzz-icu.so  /home/bot/toolchain_env_wandboard-mesa-wpe-candidate/sysroots/cortexa9t2hf-neon-poky-linux-gnueabi/usr/lib/libwpe-1.0.so  /home/bot/toolchain_env_wandboard-mesa-wpe-candidate/sysroots/cortexa9t2hf-neon-poky-linux-gnueabi/usr/lib/libatk-1.0.so  /home/bot/toolchain_env_wandboard-mesa-wpe-candidate/sysroots/cortexa9t2hf-neon-poky-linux-gnueabi/usr/lib/libglib-2.0.so  /home/bot/toolchain_env_wandboard-mesa-wpe-candidate/sysroots/cortexa9t2hf-neon-poky-linux-gnueabi/usr/lib/libgmodule-2.0.so  /home/bot/toolchain_env_wandboard-mesa-wpe-candidate/sysroots/cortexa9t2hf-neon-poky-linux-gnueabi/usr/lib/libsoup-2.4.so  /home/bot/toolchain_env_wandboard-mesa-wpe-candidate/sysroots/cortexa9t2hf-neon-poky-linux-gnueabi/usr/lib/libatk-bridge-2.0.so  /home/bot/toolchain_env_wandboard-mesa-wpe-candidate/sysroots/cortexa9t2hf-neon-poky-linux-gnueabi/usr/lib/libgstreamer-1.0.so && :
/home/bot/toolchain_env_wandboard-mesa-wpe-candidate/sysroots/x86_64-pokysdk-linux/usr/libexec/arm-poky-linux-gnueabi/gcc/arm-poky-linux-gnueabi/11.3.0/ld: error: lib/libWPEWebKit-1.0.so.3.19.0: ELF section name out of range
collect2: error: ld returned 1 exit status
```