Bug 240963 - Define WK_NOT_NO in SDKVariant.xcconfig
Summary: Define WK_NOT_NO in SDKVariant.xcconfig
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-26 11:33 PDT by David Quesada
Modified: 2022-05-26 14:13 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Quesada 2022-05-26 11:33:26 PDT 
The WK_NOT_ build settings can invert "" to "YES" and "YES" to "NO", but can't invert "NO" to "YES". This is problematic for other build configuration that builds upon this construction and only ever expects a value of YES or NO. `WK_NOT_NO` should be defined, with a value of "YES".
Comment 1 Radar WebKit Bug Importer 2022-05-26 11:34:10 PDT 
<rdar://problem/93984643>
Comment 2 David Quesada 2022-05-26 11:48:38 PDT 
https://github.com/WebKit/WebKit/pull/1058
Comment 3 EWS 2022-05-26 14:13:13 PDT 
Committed r294897 (251020@main): <https://commits.webkit.org/251020@main>

Reviewed commits have been landed. Closing PR #1058 and removing active labels.