Bug 240914 - Move some of the work from Element::insertedIntoAncestor() / removedFromAncestor() to subclasses
Summary: Move some of the work from Element::insertedIntoAncestor() / removedFromAnces...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-25 10:38 PDT by Chris Dumez
Modified: 2022-05-26 22:47 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-05-25 10:38:49 PDT 
Move some of the work from Element::insertedIntoAncestor() / removedFromAncestor() to subclasses. These functions are hot and should be kept as efficient as possible. There is no reason for every Element to pay run-time cost for checks that only apply to article or label elements.
Comment 1 Chris Dumez 2022-05-25 10:49:30 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/1017
Comment 2 EWS 2022-05-26 22:46:48 PDT 
Committed r294930 (251041@main): <https://commits.webkit.org/251041@main>

Reviewed commits have been landed. Closing PR #1017 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-05-26 22:47:14 PDT 
<rdar://problem/94017378>