Created attachment 459740 [details]
Patch

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

Comment on attachment 459740 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459740&action=review

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm:2224
>  {

this would need some context in the commit message.
If you've not updated your checkout, maybe you need to do pull.
The commit messages come now from the commit message instead of ChangeLog files.

Do we have any idea in which specific case this happens? In other words, can we write a test for it?

Comment on attachment 459740 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459740&action=review

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm:2232
> +    ASSERT(mRenderEncoder.valid());

Is this really right? ASSERT()s are supposed to only be for things that are provably true.

Created attachment 459782 [details]
For landing

At the time, happened on earth.google.com.
Most likely started happening once we increased the max uniforms?
Could be tested in WebGL test suite, bug 240948.

Committed r294877 (251007@main): <https://commits.webkit.org/251007@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459782 [details].

<rdar://problem/93967506>