Bug 240831 - WebKit projects should be consistent about whether `WK_USE_OVERRIDE_FRAMEWORKS_DIR` is enabled for Mac Catalyst
Summary: WebKit projects should be consistent about whether `WK_USE_OVERRIDE_FRAMEWORK...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-23 15:05 PDT by Elliott Williams
Modified: 2022-05-24 14:50 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-05-23 15:05:04 PDT 
Catalyst builds install content to /System/iOSSupport by setting WK_ALTERNATE_FRAMEWORKS_DIR. In some projects, WK_ALTERNATE_FRAMEWORKS_DIR affects WK_OVERRIDE_FRAMEWORKS_DIR, but since r230958, others keep the two build settings separate.

There is value in logically separating alternate and override directories, as it makes it easier to distinguish between system-installed builds such as Mac Catalyst, and self-contained builds such as Safari Technology Preview. I suggest we resolve the inconsistency by using r230958's logic everywhere.
Comment 1 Radar WebKit Bug Importer 2022-05-23 15:05:48 PDT 
<rdar://problem/93786889>
Comment 2 Elliott Williams 2022-05-23 16:44:46 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/951
Comment 3 EWS 2022-05-24 14:50:31 PDT 
Committed r294767 (250932@main): <https://commits.webkit.org/250932@main>

Reviewed commits have been landed. Closing PR #951 and removing active labels.