240785 – input[type=search] preferred content width should not include decorations

Bug 240785 - input[type=search] preferred content width should not include decorations

Summary: input[type=search] preferred content width should not include decorations

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Layout and Rendering (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Tim Nguyen (:ntim)

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2022-05-22 23:13 PDT by Tim Nguyen (:ntim)
Modified:	2022-11-02 11:22 PDT (History)
CC List:	5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tim Nguyen (:ntim) 2022-05-22 23:13:43 PDT Comment hidden (obsolete)

The searchfield still allocates space for the search clear button due to CSS in themeAdwaita.css.

To fix this, styles added on ::-webkit-search-cancel-button from themeAdwaita.css need to be set by RenderThemeAdwaita.cpp instead in adjustSearchFieldCancelButtonStyle, notably width/height.

Comment 1 Tim Nguyen (:ntim) 2022-05-30 05:35:19 PDT

actually there's a better fix

Comment 2 Radar WebKit Bug Importer 2022-05-30 05:36:12 PDT

<rdar://problem/94113204>

Comment 3 Tim Nguyen (:ntim) 2022-05-30 07:14:31 PDT

Pull request: https://github.com/WebKit/WebKit/pull/1161

Comment 4 EWS 2022-08-19 08:40:40 PDT

Committed 253595@main (5f2088ec9415): <https://commits.webkit.org/253595@main>

Reviewed commits have been landed. Closing PR #1161 and removing active labels.

Comment 5 EWS 2022-08-20 11:22:23 PDT

Test gardening commit 253620@main (19719edc4942): <https://commits.webkit.org/253620@main>

Reviewed commits have been landed. Closing PR #3505 and removing active labels.

Comment 6 Dawn Morningstar 2022-11-01 14:51:17 PDT

Re-opening for pull request https://github.com/apple/WebKit/pull/179