Bug 240775 - Web Inspector: Layout panel doesn't always match visible nodes/order of nodes in document
Summary: Web Inspector: Layout panel doesn't always match visible nodes/order of nodes...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-22 12:58 PDT by Patrick Angle
Modified: 2022-05-23 16:43 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2022-05-22 12:58:16 PDT
Layout panel does not show nodes in document order, doesn't always show newly attached nodes, and sometimes shows detached nodes because it doesn't observer NodeInserted/NodeRemoved, and just appends new layout containers to the end of the list. This is an issue for sites that dynamically add/remove elements from the DOM (including Web Inspector itself) because element order is not stable and detached nodes won't be able to have their overlays turned on in the backend anyways.
Comment 1 Radar WebKit Bug Importer 2022-05-22 12:58:23 PDT
<rdar://problem/93727833>
Comment 2 Patrick Angle 2022-05-22 16:14:58 PDT
Pull request: https://github.com/WebKit/WebKit/pull/897
Comment 3 EWS 2022-05-23 16:43:17 PDT
Committed r294695 (250897@main): <https://commits.webkit.org/250897@main>

Reviewed commits have been landed. Closing PR #897 and removing active labels.