Bug 240732 - [git-webkit] Use --git-common-dir over hard-coded .git
Summary: [git-webkit] Use --git-common-dir over hard-coded .git
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
: 240682 (view as bug list)
Depends on:
Blocks: 239082
  Show dependency tree / graph
 
Reported: 2022-05-20 13:49 PDT by Jonathan Bedard
Modified: 2022-05-26 14:56 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-05-20 13:49:58 PDT 
As Sam Sneddon pointed out, using a hard coded .git to find our config location will break if folks are using git work trees. We should use `git rev-parse --git-common-dir` instead.
Comment 1 Radar WebKit Bug Importer 2022-05-20 13:50:14 PDT 
<rdar://problem/93676555>
Comment 2 Jonathan Bedard 2022-05-20 13:54:55 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/851
Comment 3 Alexey Proskuryakov 2022-05-20 18:08:25 PDT 
*** Bug 240682 has been marked as a duplicate of this bug. ***
Comment 4 EWS 2022-05-26 14:56:37 PDT 
Committed r294900 (251023@main): <https://commits.webkit.org/251023@main>

Reviewed commits have been landed. Closing PR #851 and removing active labels.