Bug 240645 - REGRESSION(r294215): : r294317 was reverted, it fixed an edge-case for 294215
Summary: REGRESSION(r294215): : r294317 was reverted, it fixed an edge-case for 294215
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 240417 240654
  Show dependency treegraph
 
Reported: 2022-05-19 06:12 PDT by WebKit Commit Bot
Modified: 2022-05-25 12:06 PDT (History)
3 users (show)

See Also:


Attachments
REVERT of r294215 (10.30 KB, patch)
2022-05-19 06:12 PDT, WebKit Commit Bot
no flags Details | Formatted Diff | Diff
Patch (11.25 KB, patch)
2022-05-24 04:25 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
[fast-cq] For landing (11.22 KB, patch)
2022-05-25 12:00 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2022-05-19 06:12:14 PDT
https://commits.webkit.org/r294215 introduced a regression:
: r294317 was reverted, it fixed an edge-case for 294215

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2022-05-19 06:12:21 PDT
Created attachment 459584 [details]
REVERT of r294215

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Kimmo Kinnunen 2022-05-24 04:25:44 PDT
Created attachment 459712 [details]
Patch
Comment 3 EWS 2022-05-25 02:31:04 PDT
Commit message contains (OOPS!), blocking PR #None
Comment 4 Kimmo Kinnunen 2022-05-25 12:00:23 PDT
Created attachment 459764 [details]
[fast-cq] For landing
Comment 5 Radar WebKit Bug Importer 2022-05-25 12:02:00 PDT
<rdar://problem/93919054>
Comment 6 EWS 2022-05-25 12:05:56 PDT
Committed r294816 (250969@main): <https://commits.webkit.org/250969@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459764 [details].