Bug 240621 - [git-webkit] Question 'Are you sure want to setup a fork?' always returns 'Yes'
Summary: [git-webkit] Question 'Are you sure want to setup a fork?' always returns 'Yes'
Status: RESOLVED MOVED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-18 20:41 PDT by Diego Pino
Modified: 2022-05-25 06:09 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.02 KB, patch)
2022-05-18 20:41 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2022-05-18 20:41:07 PDT 
[git-webkit] Question 'Are you sure want to setup a fork?' always returns 'Yes'
Comment 1 Diego Pino 2022-05-18 20:41:16 PDT 
Created attachment 459565 [details]
Patch
Comment 2 Diego Pino 2022-05-18 20:44:05 PDT 
This comparison:

```
option.lower().startswith(response.lower()):
```

is always true when response is an empty string. Thus, the first option is always selected instead of the default option (which is what it's expected when the use doesn't introduce any input).
Comment 3 Diego Pino 2022-05-18 21:20:36 PDT 
Pushed it at https://github.com/WebKit/WebKit/pull/764