Bug 240486 - Don't synchronously flush when destroying RemoteImageBufferProxy
Summary: Don't synchronously flush when destroying RemoteImageBufferProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-16 16:03 PDT by Matt Woodrow
Modified: 2022-05-17 15:43 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2022-05-16 16:06 PDT, Matt Woodrow 		sabouhallawa: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (971 bytes, patch)
2022-05-17 14:08 PDT, Matt Woodrow 		mattwoodrow: commit-queue+
Details | Formatted Diff | Diff
Patch for landing (1.11 KB, patch)
2022-05-17 14:17 PDT, Matt Woodrow 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2022-05-16 16:03:40 PDT 
<rdar://90952989>

I don't think there's a need to synchronously flush from destruction, we should be able to just flush without waiting.

This hopefully improves PLT performance when navigating between pages (haven't managed to get a successful AB test on the bots).
Comment 1 Matt Woodrow 2022-05-16 16:06:58 PDT 
Created attachment 459463 [details]
Patch
Comment 2 Matt Woodrow 2022-05-17 14:08:06 PDT 
Created attachment 459514 [details]
Patch for landing
Comment 3 Matt Woodrow 2022-05-17 14:17:09 PDT 
Created attachment 459515 [details]
Patch for landing
Comment 4 EWS 2022-05-17 15:43:10 PDT 
Committed r294355 (250662@main): <https://commits.webkit.org/250662@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459515 [details].