Bug 240448 - [css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical appearance values internal
Summary: [css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-16 01:27 PDT by Tim Nguyen (:ntim)
Modified: 2022-05-16 03:27 PDT (History)
8 users (show)

See Also:


Attachments
Patch (47.61 KB, patch)
2022-05-16 02:22 PDT, Tim Nguyen (:ntim)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-05-16 01:27:56 PDT
These are only used internally, but not externally, so we should keep them in the ControlPart enum, but unexpose the CSS value.
Comment 1 Radar WebKit Bug Importer 2022-05-16 01:28:03 PDT
<rdar://problem/93332035>
Comment 2 Tim Nguyen (:ntim) 2022-05-16 02:22:45 PDT
Created attachment 459409 [details]
Patch
Comment 3 Tim Nguyen (:ntim) 2022-05-16 02:25:00 PDT
Pull Request: https://github.com/WebKit/WebKit/pull/632
Comment 4 EWS 2022-05-16 03:27:46 PDT
Committed r294226 (250584@main): <https://commits.webkit.org/250584@main>

Reviewed commits have been landed. Closing PR #632 and removing active labels.