Bug 240334 - Add logging when taking a process assertion synchronously
Summary: Add logging when taking a process assertion synchronously
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-12 01:55 PDT by youenn fablet
Modified: 2022-05-16 00:17 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2022-05-12 02:23 PDT, youenn fablet 		cdumez: review+
Details | Formatted Diff | Diff
Patch for landing (3.02 KB, patch)
2022-05-15 23:20 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-05-12 01:55:48 PDT 
Add logging when taking a process assertion synchronously
Comment 1 youenn fablet 2022-05-12 02:23:41 PDT 
Created attachment 459214 [details]
Patch
Comment 2 Chris Dumez 2022-05-13 07:25:28 PDT 
Comment on attachment 459214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459214&action=review

> Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:370
> +    RELEASE_LOG(ProcessSuspension, "%p - ProcessAssertion: Trying to take RBS assertion '%{public}s' for process with PID=%d", this, m_reason.utf8().data(), m_pid);

Please put method name in the logging:
ProcessAssertion::acquireSync: not ProcessAssertion:
Comment 3 youenn fablet 2022-05-15 23:20:07 PDT 
Created attachment 459402 [details]
Patch for landing
Comment 4 EWS 2022-05-16 00:16:09 PDT 
Committed r294222 (250580@main): <https://commits.webkit.org/250580@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459402 [details].
Comment 5 Radar WebKit Bug Importer 2022-05-16 00:17:13 PDT 
<rdar://problem/93329781>