Bug 240306 - [GStreamer] Refactor video rendering to a new element
Summary: [GStreamer] Refactor video rendering to a new element
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-11 06:57 PDT by Philippe Normand
Modified: 2022-05-15 09:29 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2022-05-11 06:57:02 PDT 
Using appsink with pad probes is not great.
Comment 1 Philippe Normand 2022-05-11 07:19:32 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/587
Comment 2 Philippe Normand 2022-05-15 09:29:00 PDT 
This is quite risky actually. If we move to the GstVideoSink base class we loose the unlock/unlock_stop implementations of appsink. We would also loose some flushing handling that is handled in appsink already.

I'd keep this improvement for later. There are too many tasks more important than this one.

For now we can handle the video meta in the existing pad probe, without breaking anything in the critical video rendering code.