RESOLVED LATER240306
[GStreamer] Refactor video rendering to a new element 
https://bugs.webkit.org/show_bug.cgi?id=240306
Summary [GStreamer] Refactor video rendering to a new element
Philippe Normand
Reported 2022-05-11 06:57:02 PDT
Using appsink with pad probes is not great.
Attachments
Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2022-05-11 07:19:32 PDT
Pull request: https://github.com/WebKit/WebKit/pull/587
Philippe Normand
Comment 2 2022-05-15 09:29:00 PDT
This is quite risky actually. If we move to the GstVideoSink base class we loose the unlock/unlock_stop implementations of appsink. We would also loose some flushing handling that is handled in appsink already. I'd keep this improvement for later. There are too many tasks more important than this one. For now we can handle the video meta in the existing pad probe, without breaking anything in the critical video rendering code.
Note You need to log in before you can comment on or make changes to this bug.