Bug 240268 - [Cocoa] fast/text/international/generic-font-family-language-traditional.html is failing due to language minimization
Summary: [Cocoa] fast/text/international/generic-font-family-language-traditional.html...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-09 21:11 PDT by Chris Dumez
Modified: 2022-07-11 18:55 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-05-09 21:11:19 PDT
fast/text/international/generic-font-family-language-traditional.html is failing due to language minimization.
Comment 1 Radar WebKit Bug Importer 2022-05-16 21:12:13 PDT
<rdar://problem/93394618>
Comment 2 Myles C. Maxfield 2022-05-20 18:58:05 PDT
cachedUserPrefersSimplified() should probably say

static bool cached = computeUserPrefersSimplified();

instead of

static bool cached = false;
Comment 3 Myles C. Maxfield 2022-05-20 19:12:26 PDT
This is kind of interesting. We're saying the language list ["en", "zh-tw"] gets minimized to ["en"], which then removes the signal about whether we should render simplified or traditional Chinese.

On one hand, this is kind of good, because the whole point of minimization is to make different browser configurations in the same bucket as identical. On the other hand, it means a user with these language preferences won't get the rendering they expect.

I could change the test to just use the language list ["zh-tw"] and I think it would still test the thing it's trying to test, so I guess that's probably the path forward.

🤔
Comment 4 Myles C. Maxfield 2022-05-20 19:14:43 PDT
*** Bug 240751 has been marked as a duplicate of this bug. ***
Comment 5 Myles C. Maxfield 2022-05-20 19:17:06 PDT
*** Bug 240751 has been marked as a duplicate of this bug. ***
Comment 6 Myles C. Maxfield 2022-07-11 18:55:03 PDT
Landed in https://commits.webkit.org/250878@main.