Bug 240243 - TestAPI::promiseUnhandledRejection() predominantly fails on MacOS 12.3 in --debug
Summary: TestAPI::promiseUnhandledRejection() predominantly fails on MacOS 12.3 in --d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Mac (Apple Silicon) macOS 12
: P2 Normal
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
: 240804 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-05-09 11:25 PDT by Truitt Savell
Modified: 2022-05-25 11:14 PDT (History)
11 users (show)

See Also:

Attachments
Patch (2.19 KB, patch)
2022-05-23 15:16 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Patch for landing (2.21 KB, patch)
2022-05-24 11:15 PDT, Alexey Shvayka 		ashvayka: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2022-05-09 11:25:39 PDT 
testapi

This test is flaky failing for a long time in history. I do not have a regression point. 

History:
https://results.webkit.org/?suite=javascriptcore-tests&test=testapi

build:
https://build.webkit.org/#/builders/378/builds/1036
Comment 1 Radar WebKit Bug Importer 2022-05-09 11:26:03 PDT 
<rdar://problem/92975620>
Comment 2 Alexey Proskuryakov 2022-05-09 13:45:01 PDT 
I'm not entirely sure how to interpret testapi output, but looks like there is more that one failure:

callback should receive rejected promise as first argument: FAILED
callback should receive rejection reason as second argument: FAILED
callback should not receive a third argument: PASSED

C-API tests in C++ had 2 failures

ASSERTION FAILED: !testCAPIViaCpp(filter)
/Volumes/Data/worker/Apple-Monterey-Debug-Build/build/Source/JavaScriptCore/API/tests/testapi.c(1409) : int main(int, char **)
1   0x112cb4ab0 WTFCrash
2   0x100823f80 main
3   0x100ced088
Comment 3 Mark Lam 2022-05-09 14:34:48 PDT 
I've also seen this fail intermittently on a Release build on M1 (when testapi is run while some heavy load is running in the background like a WebKit build).  I've never seen it on a Debug build yet.
Comment 4 Ryan Haddad 2022-05-23 09:18:07 PDT 
*** Bug 240804 has been marked as a duplicate of this bug. ***
Comment 5 Alexey Shvayka 2022-05-23 15:16:53 PDT 
Created attachment 459688 [details]
Patch
Comment 6 Mark Lam 2022-05-23 16:09:05 PDT 
Comment on attachment 459688 [details]
Patch

LGTM
Comment 7 Alexey Shvayka 2022-05-24 11:15:36 PDT 
Created attachment 459728 [details]
Patch for landing
Comment 8 Mark Lam 2022-05-24 16:51:45 PDT 
https://github.com/WebKit/WebKit/pull/989
Comment 9 EWS 2022-05-25 11:14:00 PDT 
Committed r294811 (250965@main): <https://commits.webkit.org/250965@main>

Reviewed commits have been landed. Closing PR #989 and removing active labels.