Bug 240177 - Remove unused ApplePayRemoteUIEnabled flag now that it is always enabled
Summary: Remove unused ApplePayRemoteUIEnabled flag now that it is always enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-06 11:34 PDT by Brent Fulgham
Modified: 2022-05-06 15:35 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.28 KB, patch)
2022-05-06 11:37 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2022-05-06 11:34:33 PDT 
Remove the internal WKPreference for ApplePayRemoteUIEnabled now that we always use the high-security ApplePay UI.
Comment 1 Brent Fulgham 2022-05-06 11:37:32 PDT 
Created attachment 458965 [details]
Patch
Comment 2 Devin Rousso 2022-05-06 14:33:24 PDT 
Comment on attachment 458965 [details]
Patch

r=me

there's probably some stuff we could remove (or just limit to `PLATFORM(MAC)` or `#if !ENABLE(APPLE_PAY_REMOTE_UI)`) in the UIProcess on iOS (e.g. all the `ENABLE(APPLE_PAY)` things in `WebPageProxy`) , but it's not a huge deal to leave it there (though it currently (and in the future) won't be used on iOS)
Comment 3 EWS 2022-05-06 15:34:19 PDT 
Committed r293928 (250375@main): <https://commits.webkit.org/250375@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458965 [details].
Comment 4 Radar WebKit Bug Importer 2022-05-06 15:35:14 PDT 
<rdar://problem/92884273>