Bug 240164 - Optimize shouldApplyContainment methods
Summary: Optimize shouldApplyContainment methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari 15
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-06 04:16 PDT by Rob Buis
Modified: 2022-05-06 19:09 PDT (History)
13 users (show)

See Also:

Attachments
Patch (13.36 KB, patch)
2022-05-06 04:20 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (12.32 KB, patch)
2022-05-06 10:56 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2022-05-06 04:16:58 PDT 
Optimize shouldApplyContainment methods by allowing OptionSet as a parameter.
Also restrict the principal box checks to a single location.
Comment 1 Rob Buis 2022-05-06 04:20:19 PDT 
Created attachment 458946 [details]
Patch
Comment 2 Simon Fraser (smfr) 2022-05-06 08:55:12 PDT 
I was going to do something very similar, but first I wanted to move these functions: bug 240156
Comment 3 Simon Fraser (smfr) 2022-05-06 08:58:54 PDT 
I can adapt this patch to the moved functions once bug 240156 lands.
Comment 4 Rob Buis 2022-05-06 09:04:15 PDT 
(In reply to Simon Fraser (smfr) from comment #3)
> I can adapt this patch to the moved functions once bug 240156 lands.

Thanks, sounds good!
Comment 5 Simon Fraser (smfr) 2022-05-06 10:56:14 PDT 
Created attachment 458963 [details]
Patch
Comment 6 EWS 2022-05-06 19:08:13 PDT 
Committed r293943 (250389@main): <https://commits.webkit.org/250389@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458963 [details].
Comment 7 Radar WebKit Bug Importer 2022-05-06 19:09:14 PDT 
<rdar://problem/92893054>