Bug 240138 - Skip failing intl tests
Summary: Skip failing intl tests
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Angelos Oikonomopoulos
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-05 13:46 PDT by Angelos Oikonomopoulos
Modified: 2022-05-09 00:01 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.68 KB, patch)
2022-05-05 13:48 PDT, Angelos Oikonomopoulos 		mcatanzaro: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Angelos Oikonomopoulos 2022-05-05 13:46:58 PDT 
Skip failing intl tests
Comment 1 Angelos Oikonomopoulos 2022-05-05 13:48:54 PDT 
Created attachment 458911 [details]
Patch
Comment 2 Michael Catanzaro 2022-05-05 14:06:57 PDT 
Comment on attachment 458911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458911&action=review

> JSTests/stress/intl-numberformat-rounding-increment-resolved-match-v3.js:1
> +//@ skip if ["arm", "mips"].include?($architecture)

This affects all architectures though (e.g. https://bugs.webkit.org/show_bug.cgi?id=240102#c4).
Comment 3 Angelos Oikonomopoulos 2022-05-05 14:21:45 PDT 
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 458911 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458911&action=review
> 
> > JSTests/stress/intl-numberformat-rounding-increment-resolved-match-v3.js:1
> > +//@ skip if ["arm", "mips"].include?($architecture)
> 
> This affects all architectures though (e.g.
> https://bugs.webkit.org/show_bug.cgi?id=240102#c4).

Ah, I missed that comment. In any case, traveling so can't take a look at the actual issue, just thought I'd keep the buildbots green over the weekend.
Comment 4 Michael Catanzaro 2022-05-06 07:33:29 PDT 
It should be fixed by https://commits.webkit.org/250323@trunk. Please confirm when you get a chance.
Comment 5 Angelos Oikonomopoulos 2022-05-09 00:00:54 PDT 
(In reply to Michael Catanzaro from comment #4)
> It should be fixed by https://commits.webkit.org/250323@trunk. Please
> confirm when you get a chance.

Yup, fixed.
Comment 6 Radar WebKit Bug Importer 2022-05-09 00:01:12 PDT 
<rdar://problem/92942348>