Bug 240129 - Remove abandoned WKPreference for SelectionPaintingWithoutSelectionGaps
Summary: Remove abandoned WKPreference for SelectionPaintingWithoutSelectionGaps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-05 10:57 PDT by Brent Fulgham
Modified: 2022-05-06 14:12 PDT (History)
11 users (show)

See Also:

Attachments
Patch (6.44 KB, patch)
2022-05-05 11:01 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2022-05-05 10:57:41 PDT 
This setting was added in Bug 156900 for the EFL port, which has since left the WebKit project. As the port is no longer buildable, and this code is never used outside of EFL, we should remove this dead code.
Comment 1 Brent Fulgham 2022-05-05 11:01:40 PDT 
Created attachment 458894 [details]
Patch
Comment 2 Chris Dumez 2022-05-05 15:55:21 PDT 
Comment on attachment 458894 [details]
Patch

What about this check?
Source/WebCore/rendering/RenderBlock.cpp:    if (settings().selectionPaintingWithoutSelectionGapsEnabled())
Comment 3 Brent Fulgham 2022-05-05 16:14:41 PDT 
(In reply to Chris Dumez from comment #2)
> Comment on attachment 458894 [details]
> Patch
> 
> What about this check?
> Source/WebCore/rendering/RenderBlock.cpp:    if
> (settings().selectionPaintingWithoutSelectionGapsEnabled())

Right -- this conditional is always 'false' for non-EFL builds, so there's no point in having the preference, or calling that method (and performing that test) on any active WebKit port.
Comment 4 EWS 2022-05-06 14:11:55 PDT 
Committed r293923 (250370@main): <https://commits.webkit.org/250370@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458894 [details].
Comment 5 Radar WebKit Bug Importer 2022-05-06 14:12:13 PDT 
<rdar://problem/92879882>