Bug 240090 - [bugs.webkit.org] Replace svn.webkit.org in committers autocomplete
Summary: [bugs.webkit.org] Replace svn.webkit.org in committers autocomplete
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-05-04 15:44 PDT by Jonathan Bedard
Modified: 2022-07-13 07:02 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-05-04 15:44:19 PDT 
We should replace svn.webkit.org in our committers autocomplete with GitHub.
Comment 1 Radar WebKit Bug Importer 2022-05-04 15:44:44 PDT 
<rdar://problem/92758558>
Comment 2 Jonathan Bedard 2022-05-04 15:46:55 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/508
Comment 3 Alexey Proskuryakov 2022-05-05 08:10:09 PDT 
Is there any difference in cache expiration? We want it to be cached I think, but also want to revalidate somewhat frequently to pick up updates.
Comment 4 Jonathan Bedard 2022-05-05 08:45:22 PDT 
(In reply to Alexey Proskuryakov from comment #3)
> Is there any difference in cache expiration? We want it to be cached I
> think, but also want to revalidate somewhat frequently to pick up updates.

There is a difference.

svn.webkit.org serves `Cache-Control: max-age=604800`, which is 7 days.

This morning, GitHub is serving `expires: Thu, 05 May 2022 15:22:02 GMT`, which is basically 5 minutes.

5 minutes is shorter than I'd want, but I'm not sure I feel strongly enough to make code or services more complicated to fix that.
Comment 5 Alexey Proskuryakov 2022-05-05 09:35:13 PDT 
That's probably better than 7 days.
Comment 6 Jonathan Bedard 2022-05-05 11:30:52 PDT 
(In reply to Alexey Proskuryakov from comment #5)
> That's probably better than 7 days.

I feel like ideally it would be a few hours, but I think we can live with 5 minutes.
Comment 7 EWS 2022-05-05 11:32:46 PDT 
Committed r293849 (250319@main): <https://commits.webkit.org/250319@main>

Reviewed commits have been landed. Closing PR #508 and removing active labels.