Bug 239913 - [CMake] Add a macro to set source file language
Summary: [CMake] Add a macro to set source file language
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-29 14:25 PDT by Don Olmstead
Modified: 2022-04-29 15:24 PDT (History)
11 users (show)

See Also:

Attachments
WIP Patch (10.59 KB, patch)
2022-04-29 15:06 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2022-04-29 14:25:27 PDT 
After the change in r239873 the Visual Studio build for PlayStation fails due to the unified c file being compiled with -std=c++. Specify the language type to get around this.
Comment 1 Don Olmstead 2022-04-29 15:06:03 PDT 
Created attachment 458611 [details]
WIP Patch
Comment 2 Stephan Szabo 2022-04-29 15:24:52 PDT 
I'm not sure how you will want to handle https://github.com/WebKit/WebKit/blob/main/Source/bmalloc/CMakeLists.txt#L685-L696 with this. It happens after the WEBKIT_FRAMEWORK* in the file, so if I'm reading this right we'll set the standard to a C language standard but then later change the compile language to C++.