Bug 239877 - [LBSE] ENABLE_LAYER_BASED_SVG_ENGINE needs to match for iOS and macOS
Summary: [LBSE] ENABLE_LAYER_BASED_SVG_ENGINE needs to match for iOS and macOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords: InRadar
Depends on:
Blocks: 90738
  Show dependency tree / graph
 
Reported: 2022-04-28 17:05 PDT by Simon Fraser (smfr)
Modified: 2022-05-18 04:24 PDT (History)
13 users (show)

See Also:

Attachments
Patch, v1 (1.19 KB, patch)
2022-05-06 01:26 PDT, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch, v2 (3.45 KB, patch)
2022-05-16 04:25 PDT, Nikolas Zimmermann 		simon.fraser: review+
zimmermann: commit-queue+
Details | Formatted Diff | Diff
[fast-cq] Patch, v3 (removed ChangeLogs for landing) (1.87 KB, patch)
2022-05-18 04:16 PDT, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-04-28 17:05:58 PDT 
https://trac.webkit.org/changeset/286204/webkit added:

#if !defined(ENABLE_LAYER_BASED_SVG_ENGINE) && PLATFORM(MAC)
#define ENABLE_LAYER_BASED_SVG_ENGINE 1
#endif

We don't want the value of ENABLE_LAYER_BASED_SVG_ENGINE to differ between macOS and iOS. For testing and performance consistency, it has to be the same for all Cocoa platforms.
Comment 1 Nikolas Zimmermann 2022-05-05 13:32:22 PDT 
I was not aware of that. Shall I prepare a fix?
Comment 2 Simon Fraser (smfr) 2022-05-05 14:24:28 PDT 
Please do.
Comment 3 Radar WebKit Bug Importer 2022-05-05 17:06:13 PDT 
<rdar://problem/92829309>
Comment 4 Nikolas Zimmermann 2022-05-06 01:26:15 PDT 
Created attachment 458939 [details]
Patch, v1
Comment 5 Nikolas Zimmermann 2022-05-16 04:25:31 PDT 
Created attachment 459414 [details]
Patch, v2
Comment 6 Nikolas Zimmermann 2022-05-18 01:31:18 PDT 
Comment on attachment 459414 [details]
Patch, v2

Let's see if cq can process this even with the ChangeLog changes...
Comment 7 Nikolas Zimmermann 2022-05-18 04:16:00 PDT 
Created attachment 459535 [details]
[fast-cq] Patch, v3 (removed ChangeLogs for landing)
Comment 8 EWS 2022-05-18 04:24:23 PDT 
Committed r294389 (250684@main): <https://commits.webkit.org/250684@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459535 [details].