Bug 239795 - REGRESSION(r293455): 293442 Broke some internal non-PGO builds
Summary: REGRESSION(r293455): 293442 Broke some internal non-PGO builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords: InRadar
Depends on:
Blocks: 239681
  Show dependency tree / graph
 
Reported: 2022-04-26 16:37 PDT by WebKit Commit Bot
Modified: 2022-04-26 17:25 PDT (History)
2 users (show)

See Also:

Attachments
REVERT of r293455 (6.42 KB, patch)
2022-04-26 16:37 PDT, WebKit Commit Bot 		no flags Details | Formatted Diff | Diff
REVERT of r293442 (13.55 KB, patch)
2022-04-26 16:58 PDT, Elliott Williams 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2022-04-26 16:37:22 PDT 
https://commits.webkit.org/r293455 introduced a regression:
293442 Broke some internal non-PGO builds

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2022-04-26 16:37:26 PDT 
Created attachment 458409 [details]
REVERT of r293455

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Elliott Williams 2022-04-26 16:58:52 PDT 
Created attachment 458410 [details]
REVERT of r293442

webkit-patch seemed to only revert the second of the two commits. Here's a manually-crafted revert patch.
Comment 3 EWS 2022-04-26 17:24:48 PDT 
Committed r293486 (250020@main): <https://commits.webkit.org/250020@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458410 [details].
Comment 4 Radar WebKit Bug Importer 2022-04-26 17:25:11 PDT 
<rdar://problem/92368335>