Bug 239750 - [Cocoa] Seeking into a xHE-AAC track backed by a SourceBuffer can stall playback
Summary: [Cocoa] Seeking into a xHE-AAC track backed by a SourceBuffer can stall playback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-25 17:27 PDT by Jer Noble
Modified: 2022-05-06 09:50 PDT (History)
9 users (show)

See Also:

Attachments
Patch (329.20 KB, patch)
2022-04-25 17:33 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (329.15 KB, patch)
2022-05-05 08:34 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (330.08 KB, patch)
2022-05-05 10:33 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2022-04-25 17:27:13 PDT 
[Cocoa] Seeking into a xHE-AAC track backed by a SourceBuffer can stall playback
Comment 1 Jer Noble 2022-04-25 17:27:34 PDT 
<rdar://91922569>
Comment 2 Jer Noble 2022-04-25 17:33:20 PDT 
Created attachment 458319 [details]
Patch
Comment 3 Eric Carlson 2022-04-25 17:37:32 PDT 
Comment on attachment 458319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458319&action=review

> Source/WebCore/ChangeLog:17
> +        AVSampleBufferAudioRenderer does not us the DoNotDisplay sample attachment to control this

s/us/use/
Comment 4 Jer Noble 2022-05-05 08:34:03 PDT 
Created attachment 458875 [details]
Patch for landing
Comment 5 Jer Noble 2022-05-05 10:33:42 PDT 
Created attachment 458887 [details]
Patch for landing
Comment 6 EWS 2022-05-06 09:50:23 PDT 
Committed r293899 (?): <https://commits.webkit.org/r293899>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458887 [details].