Bug 239679 - Fix build error caused by LTO + Unified Sources
Summary: Fix build error caused by LTO + Unified Sources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Michaud
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-22 17:43 PDT by Justin Michaud
Modified: 2022-04-23 14:49 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2022-04-22 17:44 PDT, Justin Michaud 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Michaud 2022-04-22 17:43:00 PDT 
Fix build error caused by LTO + Unified Sources
Comment 1 Justin Michaud 2022-04-22 17:44:31 PDT 
Created attachment 458189 [details]
Patch
Comment 2 Mark Lam 2022-04-22 17:49:50 PDT 
Comment on attachment 458189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458189&action=review

rs=me ... too

> Source/WebCore/ChangeLog:3
> +        Fix build error caused by LTO + Unified Sources

nit: We'll typically say something like "Speculative fix for build error caused by LTO + Unified Sources" so that reviewers will know that the fix is of a speculative nature.
Comment 3 Justin Michaud 2022-04-23 12:23:16 PDT 
I confirmed that this fixes the build error. I'll give Mac-debug another shot to run and then merge.
Comment 4 Justin Michaud 2022-04-23 14:39:38 PDT 
Mac-debug timing out appears to be a known issue, landing.
Comment 5 EWS 2022-04-23 14:48:07 PDT 
Committed r293295 (249920@main): <https://commits.webkit.org/249920@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458189 [details].
Comment 6 Radar WebKit Bug Importer 2022-04-23 14:49:14 PDT 
<rdar://problem/92221251>