Bug 239654 - [LFC][Integration] Add FlexFormattingContextIntegrationEnabled setting
Summary: [LFC][Integration] Add FlexFormattingContextIntegrationEnabled setting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-22 07:45 PDT by zalan
Modified: 2022-04-22 11:27 PDT (History)
12 users (show)

See Also:

Attachments
Patch (7.80 KB, patch)
2022-04-22 07:56 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.44 KB, patch)
2022-04-22 09:38 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-04-22 07:45:03 PDT 
ssia
Comment 1 zalan 2022-04-22 07:56:50 PDT 
Created attachment 458148 [details]
Patch
Comment 2 Antti Koivisto 2022-04-22 08:25:07 PDT 
Comment on attachment 458148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458148&action=review

> Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:310
> +  webcoreBinding: RuntimeEnabledFeatures

I know the existing LFC flags are RuntimeEnabledFeatures but I wonder if this needs to be. I think they are disfavoured for some reason.
Comment 3 zalan 2022-04-22 09:38:25 PDT 
Created attachment 458153 [details]
Patch
Comment 4 Simon Fraser (smfr) 2022-04-22 10:15:47 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 458148 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458148&action=review
> 
> > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:310
> > +  webcoreBinding: RuntimeEnabledFeatures
> 
> I know the existing LFC flags are RuntimeEnabledFeatures but I wonder if
> this needs to be. I think they are disfavoured for some reason.

Because RuntimeEnabledFeatures are per web process but the UI makes it look like it behaves like a per-Page thing, so stuff breaks when there is > 1 Page per process.
Comment 5 EWS 2022-04-22 11:26:30 PDT 
Committed r293233 (249897@main): <https://commits.webkit.org/249897@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458153 [details].
Comment 6 Radar WebKit Bug Importer 2022-04-22 11:27:14 PDT 
<rdar://problem/92178248>