Bug 239476 - [WebXR] Update Device::initializeTrackingAndRendering() to take in more parameters regarding the session setup
Summary: [WebXR] Update Device::initializeTrackingAndRendering() to take in more param...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-18 17:24 PDT by Ada Chan
Modified: 2022-04-19 13:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (17.67 KB, patch)
2022-04-18 17:32 PDT, Ada Chan 		no flags Details | Formatted Diff | Diff
Patch (17.78 KB, patch)
2022-04-18 20:42 PDT, Ada Chan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2022-04-18 17:24:06 PDT 
[WebXR] Update Device::initializeTrackingAndRendering() to take in more parameters regarding the session setup
Comment 1 Ada Chan 2022-04-18 17:32:52 PDT 
Created attachment 457845 [details]
Patch
Comment 2 Darin Adler 2022-04-18 17:37:06 PDT 
Comment on attachment 457845 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457845&action=review

> Source/WebKit/Shared/XR/XRDeviceProxy.h:32
> +#include <WebCore/SecurityOriginData.h>

Seems like this header could just use a forward declaration of WebCore::SecurityOriginData. The .cpp files can include the header.
Comment 3 Ada Chan 2022-04-18 20:42:20 PDT 
Created attachment 457852 [details]
Patch
Comment 4 Ada Chan 2022-04-18 20:43:28 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 457845 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=457845&action=review
> 
> > Source/WebKit/Shared/XR/XRDeviceProxy.h:32
> > +#include <WebCore/SecurityOriginData.h>
> 
> Seems like this header could just use a forward declaration of
> WebCore::SecurityOriginData. The .cpp files can include the header.

Yes! Fixed. Thanks for catching that!
Comment 5 EWS 2022-04-19 13:28:25 PDT 
Committed r293033 (249772@main): <https://commits.webkit.org/249772@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457852 [details].
Comment 6 Radar WebKit Bug Importer 2022-04-19 13:29:14 PDT 
<rdar://problem/91982150>