Bug 239434 - AX: Update the isolated tree in response to AXElementBusyChanged and AXTextChanged notifications
Summary: AX: Update the isolated tree in response to AXElementBusyChanged and AXTextCh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-17 08:53 PDT by Tyler Wilcock
Modified: 2022-04-18 20:26 PDT (History)
10 users (show)

See Also:

Attachments
Patch (30.19 KB, patch)
2022-04-17 09:00 PDT, Tyler Wilcock 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (29.67 KB, patch)
2022-04-17 09:30 PDT, Tyler Wilcock 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (29.67 KB, patch)
2022-04-17 10:20 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (29.80 KB, patch)
2022-04-17 10:41 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (29.96 KB, patch)
2022-04-18 15:23 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-04-17 08:53:13 PDT 
Update the isolated tree in response to AXElementBusyChanged and AXTextChanged notifications
Comment 1 Radar WebKit Bug Importer 2022-04-17 08:53:21 PDT 
<rdar://problem/91862868>
Comment 2 Tyler Wilcock 2022-04-17 09:00:03 PDT 
Created attachment 457771 [details]
Patch
Comment 3 chris fleizach 2022-04-17 09:05:18 PDT 
Comment on attachment 457771 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457771&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1302
> +void AccessibilityNodeObject::setElementAttributeValue(const QualifiedName& attributeName, bool value)

Do we still use this for anything?
Comment 4 Tyler Wilcock 2022-04-17 09:30:14 PDT 
Created attachment 457772 [details]
Patch
Comment 5 Tyler Wilcock 2022-04-17 09:30:59 PDT 
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1302
> > +void AccessibilityNodeObject::setElementAttributeValue(const QualifiedName& attributeName, bool value)
> 
> Do we still use this for anything?
Nope, good point! Removed the function entirely in the latest patch.
Comment 6 Tyler Wilcock 2022-04-17 10:20:01 PDT 
Created attachment 457773 [details]
Patch
Comment 7 Tyler Wilcock 2022-04-17 10:41:59 PDT 
Created attachment 457774 [details]
Patch
Comment 8 Andres Gonzalez 2022-04-18 13:14:37 PDT 
(In reply to Tyler Wilcock from comment #7)
> Created attachment 457774 [details]
> Patch

--- a/Source/WebCore/ChangeLog
+++ a/Source/WebCore/ChangeLog

+        Tests: accessibility/accessibility-text-updates-after-dynamic-change.html

Can we call this just accessibility/text-updates-after-dynamic-change.html?
Comment 9 Tyler Wilcock 2022-04-18 15:23:24 PDT 
Created attachment 457829 [details]
Patch
Comment 10 Tyler Wilcock 2022-04-18 20:20:31 PDT 
> +        Tests:
> accessibility/accessibility-text-updates-after-dynamic-change.html
> 
> Can we call this just accessibility/text-updates-after-dynamic-change.html?
Good idea, fixed this.
Comment 11 EWS 2022-04-18 20:26:23 PDT 
Committed r293006 (249745@main): <https://commits.webkit.org/249745@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457829 [details].