Created attachment 457759 [details] Screenshot of Issue I suspect internally these elements are using a flex renderer. Not sure if we should actually be showing these as flex containers, though. Seems like a lot of extra noise in most cases and it's not immediately apparent how this internal implementation details is relevant to most folks.
<rdar://problem/91856323>
Created attachment 458216 [details] Patch v1.0
Comment on attachment 458216 [details] Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=458216&action=review r=me, neat! > Source/WebCore/inspector/agents/InspectorCSSAgent.cpp:948 > + } NIT: should we have a `return std::nullopt` so that we don't futilely attempt to `is<RenderGrid>(renderer)`? > LayoutTests/inspector/css/nodeLayoutContextTypeChanged.html:187 > + NIT: i'd remove this so that it doesn't affect the expected output 😅
Comment on attachment 458216 [details] Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=458216&action=review >> LayoutTests/inspector/css/nodeLayoutContextTypeChanged.html:187 >> + > > NIT: i'd remove this so that it doesn't affect the expected output 😅 This isn't the new line appearing in the test output. We have the `<input type="submit" id="flexSubmitInput" />` to thank for that, unfortunately.
Created attachment 458473 [details] Patch v1.1
Committed r293565 (250079@main): <https://commits.webkit.org/250079@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458473 [details].