Bug 239396 - [PGO] Fix build on intel machines
Summary: [PGO] Fix build on intel machines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Mac (Intel) Unspecified
: P1 Critical
Assignee: Justin Michaud
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-15 11:33 PDT by Justin Michaud
Modified: 2022-04-18 11:48 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Michaud 2022-04-15 11:33:31 PDT 
For some reason this was never an issue on AS, but we should use the correct operator for string comparison.
Comment 1 Justin Michaud 2022-04-15 11:37:21 PDT 
Argument "ON" isn't numeric in numeric eq (==) at ../../Tools/Scripts/check-for-weak-vtables-and-externals line 63.
Use of uninitialized value $ENV{"ENABLE_LLVM_PROFILE_GENERATION"} in numeric eq (==) at ../../Tools/Scripts/check-for-weak-vtables-and-externals line 63.
Comment 2 Justin Michaud 2022-04-15 16:29:40 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/299
Comment 3 EWS 2022-04-18 11:47:35 PDT 
Committed r292962 (249727@main): <https://commits.webkit.org/249727@main>

Reviewed commits have been landed. Closing PR #299 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2022-04-18 11:48:16 PDT 
<rdar://problem/91907374>