Bug 239346 - InternalFunction::createSubclassStructure() should use base object's global object
Summary: InternalFunction::createSubclassStructure() should use base object's global o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Trivial
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-14 10:22 PDT by Alexey Shvayka
Modified: 2022-04-14 13:19 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.68 KB, patch)
2022-04-14 10:24 PDT, Alexey Shvayka 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2022-04-14 10:22:02 PDT 
InternalFunction::createSubclassStructure() should use base object's global object
Comment 1 Alexey Shvayka 2022-04-14 10:24:37 PDT 
Created attachment 457640 [details]
Patch
Comment 2 Darin Adler 2022-04-14 10:37:48 PDT 
Comment on attachment 457640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457640&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        Chrome and Firefox don't agree on interoperable behavior in case of cross-realm
> +        NewTarget's "prototype", so this patch aligns WebKit with Chrome to fix a web-compat issue.

In future: Where should the interoperability test go? WPT? Somewhere else?
Comment 3 Alexey Shvayka 2022-04-14 12:30:41 PDT 
Committed r292883 (249653@trunk): <https://commits.webkit.org/249653@trunk>
Comment 4 Radar WebKit Bug Importer 2022-04-14 12:31:15 PDT 
<rdar://problem/91770382>
Comment 5 Alexey Shvayka 2022-04-14 12:31:44 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 457640 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=457640&action=review
> 
> > Source/JavaScriptCore/ChangeLog:9
> > +        Chrome and Firefox don't agree on interoperable behavior in case of cross-realm
> > +        NewTarget's "prototype", so this patch aligns WebKit with Chrome to fix a web-compat issue.
> 
> In future: Where should the interoperability test go? WPT? Somewhere else?

Discussed this with Darin offline.
Comment 6 Radar WebKit Bug Importer 2022-04-14 12:31:56 PDT 
<rdar://problem/91770431>
Comment 7 Alexey Shvayka 2022-04-14 13:19:23 PDT 
Committed r292886 (249656@trunk): <https://commits.webkit.org/249656@trunk>