rdar://80059355
Created attachment 457593 [details] For EWS
Comment on attachment 457593 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=457593&action=review r=me, but it seems like iOS sim might be unhappy. > Source/WebKit/Platform/spi/ios/UIKitSPI.h:171 > +typedef NS_ENUM(NSInteger, _UIDataOwner) { Should this also be inside #if HAVE(PASTEBOARD_DATA_OWNER)?
Thanks for the review! (In reply to Kate Cheney from comment #2) > Comment on attachment 457593 [details] > For EWS > > View in context: > https://bugs.webkit.org/attachment.cgi?id=457593&action=review > > r=me, but it seems like iOS sim might be unhappy. > > > Source/WebKit/Platform/spi/ios/UIKitSPI.h:171 > > +typedef NS_ENUM(NSInteger, _UIDataOwner) { > > Should this also be inside #if HAVE(PASTEBOARD_DATA_OWNER)? Ah, so it looks like the declaration of _UIDataOwner isn't behind any version (or platform) guards, so I think it's okay to use outside of HAVE(PASTEBOARD_DATA_OWNER). More generally, _UIDataOwner is also used in several other managed data scenarios, e.g. drag-and-drop. I'm not actually sure why the iOS builder failed: https://ews-build.webkit.org/#/builders/64/builds/15499; there's no error, and the last few lines contains: ``` command timed out: 1200 seconds without output running ['perl', 'Tools/Scripts/build-webkit', '--release', 'ARCHS=x86_64', 'ONLY_ACTIVE_ARCH=NO', '--ios-simulator'], attempting to kill process killed by signal 9 program finished with exit code -1 ``` (I hit the retry button 🤞🏻)
(In reply to Wenson Hsieh from comment #3) > Thanks for the review! > > (In reply to Kate Cheney from comment #2) > > Comment on attachment 457593 [details] > > For EWS > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=457593&action=review > > > > r=me, but it seems like iOS sim might be unhappy. > > > > > Source/WebKit/Platform/spi/ios/UIKitSPI.h:171 > > > +typedef NS_ENUM(NSInteger, _UIDataOwner) { > > > > Should this also be inside #if HAVE(PASTEBOARD_DATA_OWNER)? > > Ah, so it looks like the declaration of _UIDataOwner isn't behind any > version (or platform) guards, so I think it's okay to use outside of > HAVE(PASTEBOARD_DATA_OWNER). More generally, _UIDataOwner is also used in > several other managed data scenarios, e.g. drag-and-drop. > Makes sense! > I'm not actually sure why the iOS builder failed: > https://ews-build.webkit.org/#/builders/64/builds/15499; there's no error, > and the last few lines contains: > > ``` > command timed out: 1200 seconds without output running ['perl', > 'Tools/Scripts/build-webkit', '--release', 'ARCHS=x86_64', > 'ONLY_ACTIVE_ARCH=NO', '--ios-simulator'], attempting to kill > process killed by signal 9 > program finished with exit code -1 > ``` > > (I hit the retry button 🤞🏻) !! very strange !!
Committed r292888 (249658@main): <https://commits.webkit.org/249658@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457593 [details].