Bug 239278 - [GPUP] Add logging for installed font reconstitution failure
Summary: [GPUP] Add logging for installed font reconstitution failure
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-13 00:34 PDT by Myles C. Maxfield
Modified: 2022-04-14 18:08 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.64 KB, patch)
2022-04-13 00:47 PDT, Myles C. Maxfield 		simon.fraser: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-04-13 00:34:02 PDT 
[GPUP] Add logging for installed font reconstitution failure
Comment 1 Myles C. Maxfield 2022-04-13 00:47:37 PDT 
Created attachment 457511 [details]
Patch
Comment 2 Simon Fraser (smfr) 2022-04-13 09:17:52 PDT 
Comment on attachment 457511 [details]
Patch

No need to add logging; this is reproducible.
Comment 3 Myles C. Maxfield 2022-04-13 10:07:24 PDT 
Really? I couldn’t reproduce it 🤔
Comment 4 Simon Fraser (smfr) 2022-04-13 10:48:44 PDT 
I can reproduce it with `run-webkit-tests --ios-simulator fast/text/` against an iOS 15.4 SDK
Comment 5 Simon Fraser (smfr) 2022-04-13 11:06:16 PDT 
Logging says:
Cannot reconstitute installed font in GPU process: file://iNmEmOrYcGfOnT_0x600003184580#postscript-name=Ahem (Ahem) - {
    NSFontNameAttribute = Ahem;
    NSFontSizeAttribute = 16;
}
Comment 6 Myles C. Maxfield 2022-04-13 13:06:03 PDT 
Oh! This only happens in tests! It’s because we use InjectedBundle to install Ahem just for the web process.

I wonder how to fix this 🤔 Surely we don’t want a GPU-Process-injected-bundle…

Maybe I add testing-only code in the GPU process and only enable it in WKTR? 🤔🤔🤔