Bug 239064 - [model] ASVInlinePreview objects don't get cleared when the model source changes
Summary: [model] ASVInlinePreview objects don't get cleared when the model source changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-11 03:16 PDT by Antoine Quint
Modified: 2022-04-15 02:38 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.28 KB, patch)
2022-04-11 03:19 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (25.69 KB, patch)
2022-04-14 05:18 PDT, Antoine Quint 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-04-11 03:16:22 PDT 
[model] ASVInlinePreview objects don't get cleared when the model source changes
Comment 1 Antoine Quint 2022-04-11 03:19:01 PDT 
Created attachment 457241 [details]
Patch
Comment 2 Antoine Quint 2022-04-11 03:19:08 PDT 
<rdar://problem/90391037>
Comment 3 Dean Jackson 2022-04-11 03:25:32 PDT 
Comment on attachment 457241 [details]
Patch

Can we write a test?
Comment 4 Antoine Quint 2022-04-11 07:50:28 PDT 
Yeah, we should be able to get a list of UUIDs and check whether a given UUID is still loaded.
Comment 5 Antoine Quint 2022-04-14 05:18:55 PDT 
Created attachment 457613 [details]
Patch
Comment 6 Antoine Quint 2022-04-15 02:38:00 PDT 
Committed r292902 (249672@trunk): <https://commits.webkit.org/249672@trunk>