Bug 239059 - [IFC][Integration] LayoutIntegration::LineLayout should not expose InlineContent
Summary: [IFC][Integration] LayoutIntegration::LineLayout should not expose InlineContent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-10 21:16 PDT by zalan
Modified: 2022-04-11 18:32 PDT (History)
12 users (show)

See Also:

Attachments
Patch (9.73 KB, patch)
2022-04-10 21:19 PDT, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (9.73 KB, patch)
2022-04-11 15:49 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-04-10 21:16:28 PDT 
ssia
Comment 1 zalan 2022-04-10 21:19:13 PDT 
Created attachment 457230 [details]
Patch
Comment 2 Darin Adler 2022-04-11 14:48:58 PDT 
Comment on attachment 457230 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457230&action=review

> Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:497
> +    return m_inlineContent ? m_inlineContent->hasVisualOverflow() : false;

I like writing these with &&, would you consider that?
Comment 3 zalan 2022-04-11 14:51:57 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 457230 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=457230&action=review
> 
> > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:497
> > +    return m_inlineContent ? m_inlineContent->hasVisualOverflow() : false;
> 
> I like writing these with &&, would you consider that?
good point! yes!
Comment 4 zalan 2022-04-11 15:49:20 PDT 
Created attachment 457295 [details]
Patch
Comment 5 EWS 2022-04-11 18:31:21 PDT 
Committed r292752 (249536@main): <https://commits.webkit.org/249536@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 457295 [details].
Comment 6 Radar WebKit Bug Importer 2022-04-11 18:32:15 PDT 
<rdar://problem/91601019>