Bug 238912 - Adjust and refactor some UA styles and logic for injecting Live Text
Summary: Adjust and refactor some UA styles and logic for injecting Live Text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-06 16:58 PDT by Wenson Hsieh
Modified: 2022-04-07 11:30 PDT (History)
12 users (show)

See Also:

Attachments
Patch (13.27 KB, patch)
2022-04-06 18:01 PDT, Wenson Hsieh 		akeerthi: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (13.37 KB, patch)
2022-04-07 07:53 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2022-04-06 16:58:51 PDT 
rdar://91383570
Comment 1 Wenson Hsieh 2022-04-06 18:01:25 PDT 
Created attachment 456879 [details]
Patch
Comment 2 Aditya Keerthi 2022-04-06 20:30:19 PDT 
Comment on attachment 456879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456879&action=review

> Source/WebCore/dom/ImageOverlay.cpp:445
> +            if (lines.size() > 2)

Nit: Named constant?
Comment 3 Wenson Hsieh 2022-04-07 07:52:36 PDT 
Comment on attachment 456879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456879&action=review

Thanks for the review!

>> Source/WebCore/dom/ImageOverlay.cpp:445
>> +            if (lines.size() > 2)
> 
> Nit: Named constant?

Makes sense — I'll change this to use `constexpr auto maxLineCountForCenterAlignedText = 2;`
Comment 4 Wenson Hsieh 2022-04-07 07:53:55 PDT 
Created attachment 456924 [details]
Patch for landing
Comment 5 EWS 2022-04-07 10:23:21 PDT 
Committed r292543 (249381@main): <https://commits.webkit.org/249381@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456924 [details].