Bug 238823 - Call Structure::get instead of Structure::getConcurrently on the mutator thread
Summary: Call Structure::get instead of Structure::getConcurrently on the mutator thread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-04-05 11:33 PDT by Saam Barati
Modified: 2022-04-06 12:37 PDT (History)
7 users (show)

See Also:

Attachments
patch (39.40 KB, patch)
2022-04-05 18:58 PDT, Saam Barati 		ysuzuki: review+
Details | Formatted Diff | Diff
patch for landing (39.61 KB, patch)
2022-04-06 11:05 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2022-04-05 11:33:08 PDT 
...
Comment 1 Saam Barati 2022-04-05 18:58:42 PDT 
Created attachment 456774 [details]
patch
Comment 2 Yusuke Suzuki 2022-04-05 19:56:55 PDT 
Comment on attachment 456774 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456774&action=review

r=me

> Source/JavaScriptCore/runtime/JSObject.h:1418
> +    case Concurrency::MainThread:

Let's add `ASSERT(!isCompilationThread() && !Thread::mayBeGCThread());` assertion.

> Source/JavaScriptCore/runtime/Structure.h:520
> +        case Concurrency::MainThread:

Let's add `ASSERT(!isCompilationThread() && !Thread::mayBeGCThread());` assertion.

> Source/JavaScriptCore/runtime/Structure.h:530
> +        case Concurrency::MainThread:

Let's add `ASSERT(!isCompilationThread() && !Thread::mayBeGCThread());` assertion.
Comment 3 Saam Barati 2022-04-06 11:05:23 PDT 
Created attachment 456839 [details]
patch for landing
Comment 4 EWS 2022-04-06 12:36:48 PDT 
Committed r292493 (249341@main): <https://commits.webkit.org/249341@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456839 [details].
Comment 5 Radar WebKit Bug Importer 2022-04-06 12:37:17 PDT 
<rdar://problem/91370257>