Bug 238701 - Start replacing String(const char*) constructor with a String::fromLatin1(const char*) function
Summary: Start replacing String(const char*) constructor with a String::fromLatin1(con...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 238693
Blocks:
  Show dependency tree / graph
 
Reported: 2022-04-02 12:58 PDT by Chris Dumez
Modified: 2022-04-06 12:06 PDT (History)
35 users (show)

See Also:

Attachments
Patch (95.69 KB, patch)
2022-04-05 20:28 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (94.94 KB, patch)
2022-04-05 21:44 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-04-02 12:58:12 PDT 
Replace String(const char*) constructor with a String::fromLatin1(const char*) function. It is more consistent with String::fromUTF8() and makes it clearer that input is treated as Latin-1.
Comment 1 Chris Dumez 2022-04-05 20:28:44 PDT 
Created attachment 456777 [details]
Patch
Comment 2 Chris Dumez 2022-04-05 21:44:41 PDT 
Created attachment 456782 [details]
Patch
Comment 3 Geoffrey Garen 2022-04-06 10:53:24 PDT 
Comment on attachment 456782 [details]
Patch

r=me
Comment 4 Chris Dumez 2022-04-06 12:05:36 PDT 
Comment on attachment 456782 [details]
Patch

Clearing flags on attachment: 456782

Committed r292487 (?): <https://commits.webkit.org/r292487>
Comment 5 Chris Dumez 2022-04-06 12:05:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2022-04-06 12:06:18 PDT 
<rdar://problem/91368828>