Bug 238677 - [CMake] Make PlayStation WebDriver build dependent on WPE Backend
Summary: [CMake] Make PlayStation WebDriver build dependent on WPE Backend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-01 11:55 PDT by Don Olmstead
Modified: 2023-01-05 10:36 PST (History)
7 users (show)

See Also:

Attachments
Patch (7.49 KB, patch)
2022-04-01 12:55 PDT, Don Olmstead 		ross.kirsling: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2022-04-01 11:55:12 PDT 
...
Comment 1 Don Olmstead 2022-04-01 12:55:45 PDT 
Created attachment 456391 [details]
Patch
Comment 2 Stephan Szabo 2022-04-04 09:35:01 PDT 
Comment on attachment 456391 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456391&action=review

> Source/WebKit/PlatformPlayStation.cmake:110
> +    UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp

I don't think this is correct. We should not think that webprocess will only be on for WPE even with the upstream OptionsPlayStation only setting it on in that combination because the downstream merged state will also have it on but doesn't have the wpe support.
Comment 3 Don Olmstead 2023-01-04 15:39:55 PST 
Pull request: https://github.com/WebKit/WebKit/pull/8217
Comment 4 EWS 2023-01-05 10:36:00 PST 
Committed 258489@main (e217508ca2f1): <https://commits.webkit.org/258489@main>

Reviewed commits have been landed. Closing PR #8217 and removing active labels.